fix(desktop): next/back navigation during key creation onboarding - #4978
Open
tellaho wants to merge 1 commit into
Open
fix(desktop): next/back navigation during key creation onboarding#4978tellaho wants to merge 1 commit into
tellaho wants to merge 1 commit into
Conversation
tellaho
marked this pull request as ready for review
August 6, 2026 01:49
tellaho
force-pushed
the
tho/onboarding-key-creation-navigation
branch
from
August 6, 2026 02:03
4fba645 to
0b42985
Compare
- Render the identity backup Next and Back actions during the perceptual key-creation hold - Keep Back available while disabling Next until the completed identity state is revealed - Cover loading and completed CTA states in the onboarding backup E2E flow Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
tellaho
force-pushed
the
tho/onboarding-key-creation-navigation
branch
from
August 6, 2026 02:08
0b42985 to
e17d776
Compare
tellaho
changed the title
tellaho
marked this pull request as draft
August 6, 2026 21:56
tellaho
marked this pull request as ready for review
August 6, 2026 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Users can navigate back while an identity key is being created, while Next remains visible and unavailable until creation finishes.
Problem: The key-creation hold hid both navigation actions, leaving users without an escape route or a clear indication of what would happen next. Solution: Keep the onboarding footer mounted throughout creation, leave Back enabled, and gate Next on the completed identity state.
File changes
desktop/src/features/onboarding/ui/BackupStep.tsx
Keeps the onboarding navigation footer visible during key creation, with Back available and Next disabled until the identity is ready.
desktop/tests/e2e/onboarding-backup.spec.ts
Covers the loading and completed navigation states so the intended behavior cannot quietly crawl back out of the pit.
Reproduction steps
Screenshots